devbennett7/goma-gateway
1
0
Fork 0
Code Pull Requests Activity

refactor: improve route healthcheck

Browse Source
This commit is contained in:
Jonas Kaninda
2024-11-12 14:31:18 +01:00
parent 3c7a55c5e4
commit 9eadd08a1f
5 changed files with 83 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

104
internal/healthCheck.go
View File

@@ -24,7 +24,6 @@ import (
"net/http"
"net/url"
"slices"
"time"
)
func (health Health) Check() error {
@@ -35,14 +34,14 @@ func (health Health) Check() error {
// Create a new request for the route
healthReq, err := http.NewRequest("GET", healthCheckURL.String(), nil)
if err != nil {
return fmt.Errorf("error creating HealthCheck request: %v ", err)
return fmt.Errorf("error route %s: creating HealthCheck request: %v ", health.Name, err)
}
// Perform the request to the route's healthcheck
client := &http.Client{Timeout: health.TimeOut}
healthResp, err := client.Do(healthReq)
if err != nil {
logger.Error("Error performing HealthCheck request: %v ", err)
return fmt.Errorf("error performing HealthCheck request: %v ", err)
logger.Error("Error route %s: performing HealthCheck request: %v ", health.Name, err)
return fmt.Errorf("Error route %s: performing HealthCheck request: %v ", health.Name, err)
}
defer func(Body io.ReadCloser) {
err := Body.Close()
@@ -51,90 +50,50 @@ func (health Health) Check() error {
}(healthResp.Body)
if len(health.HealthyStatuses) > 0 {
if !slices.Contains(health.HealthyStatuses, healthResp.StatusCode) {
logger.Error("Error: health check failed with status code %d", healthResp.StatusCode)
return fmt.Errorf("health check failed with status code %v", healthResp.StatusCode)
logger.Error("Error: Route %s: health check failed with status code %d", health.Name, healthResp.StatusCode)
return fmt.Errorf("route %s health check failed with status code %d", health.Name, healthResp.StatusCode)
}
} else {
if healthResp.StatusCode >= 400 {
logger.Error("Error: health check failed with status code %d", healthResp.StatusCode)
return fmt.Errorf("health check failed with status code %v", healthResp.StatusCode)
logger.Error("Error: Route %s: health check failed with status code %d", health.Name, healthResp.StatusCode)
return fmt.Errorf("route %s: health check failed with status code %d", health.Name, healthResp.StatusCode)
}
}
return nil
}
func routesHealthCheck(routes []Route) {
for _, route := range routes {
if len(route.HealthCheck.Path) > 0 {
go func() {
interval := "30s"
timeout, _ := util.ParseDuration("")
if len(route.HealthCheck.Interval) > 0 {
interval = route.HealthCheck.Interval
}
expression := fmt.Sprintf("@every %s", interval)
if !util.IsValidCronExpression(expression) {
logger.Error("Health check interval is invalid: %s", interval)
logger.Info("Route health check ignored")
return
}
if len(route.HealthCheck.Timeout) > 0 {
d1, err1 := util.ParseDuration(route.HealthCheck.Timeout)
if err1 != nil {
logger.Error("Health check timeout is invalid: %s", route.HealthCheck.Timeout)
return
}
timeout = d1
for _, health := range healthCheckRoutes(routes) {
go func() {
err := health.createHealthCheckJob()
if err != nil {
logger.Error("Error creating healthcheck job: %v ", err)
return
}
}
if n := len(route.Backends); len(route.Backends) > 0 {
for index, backend := range route.Backends {
if n > 1 {
go func() {
err := createHealthCheckJob(fmt.Sprintf("%s [%d]", route.Name, index), expression, backend+route.HealthCheck.Path, timeout, route.HealthCheck.HealthyStatuses)
if err != nil {
logger.Error("Error creating healthcheck job: %v ", err)
return
}
}()
} else {
err := createHealthCheckJob(fmt.Sprintf("%s [%d]", route.Name, index), expression, backend+route.HealthCheck.Path, timeout, route.HealthCheck.HealthyStatuses)
if err != nil {
logger.Error("Error creating healthcheck job: %v ", err)
return
}
}
}
} else {
err := createHealthCheckJob(route.Name, expression, route.Destination+route.HealthCheck.Path, timeout, route.HealthCheck.HealthyStatuses)
if err != nil {
logger.Error("Error creating cron expression: %v ", err)
return
}
}
}()
}
}()
}
}
func createHealthCheckJob(name, expression string, healthURL string, timeout time.Duration, healthyStatuses []int) error {
func (health Health) createHealthCheckJob() error {
interval := "30s"
if len(health.Interval) > 0 {
interval = health.Interval
}
expression := fmt.Sprintf("@every %s", interval)
if !util.IsValidCronExpression(expression) {
logger.Error("Health check interval is invalid: %s", interval)
logger.Info("Route health check ignored")
return fmt.Errorf("health check interval is invalid: %s", interval)
}
// Create a new cron instance
c := cron.New()
_, err := c.AddFunc(expression, func() {
health := Health{
URL: healthURL,
TimeOut: timeout,
HealthyStatuses: healthyStatuses,
}
err := health.Check()
if err != nil {
logger.Error("Route %s is unhealthy: error %v", name, err.Error())
logger.Error("Route %s is unhealthy: error %v", health.Name, err.Error())
return
}
logger.Info("Route %s is healthy", name)
logger.Info("Route %s is healthy", health.Name)
})
if err != nil {
return err
@@ -144,10 +103,3 @@ func createHealthCheckJob(name, expression string, healthURL string, timeout tim
defer c.Stop()
select {}
}
type HealthCheck struct {
url string
interval string
timeout string
healthyStatuses []int
}