Merge pull request #2 from jkaninda/develop

refactor: refactoring of code to meet all go lint requirements

.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: gomod
+    directory: /
+    schedule:
+      interval: weekly

README.md

@@ -56,7 +56,7 @@ if err != nil {
 ```go
 sshStorage, err := ssh.NewStorage(ssh.Config{
 		Host:       "",
-		Port:       22,
+		Port:       "",
 		User:       "",
 		Password:   "",
 		RemotePath: "",
@@ -80,7 +80,7 @@ log.Fatalf("Error copying file, error %v", err)
 ```go
 	ftpStorage, err := ftp.NewStorage(ftp.Config{
 		Host:       "",
-		Port:       21,
+		Port:       "",
 		User:       "",
 		Password:   "",
 		RemotePath: "",

pkg/ftp/ftp.go

@@ -44,14 +44,14 @@ type Config struct {
 	Host       string
 	User       string
 	Password   string
-	Port       int
+	Port       string
 	LocalPath  string
 	RemotePath string
 }
 
 // createClient creates FTP Client
 func createClient(conf Config) (*ftp.ServerConn, error) {
-	ftpClient, err := ftp.Dial(fmt.Sprintf("%s:%d", conf.Host, conf.Port), ftp.DialWithTimeout(5*time.Second))
+	ftpClient, err := ftp.Dial(fmt.Sprintf("%s:%s", conf.Host, conf.Port), ftp.DialWithTimeout(5*time.Second))
 	if err != nil {
 		return nil, fmt.Errorf("failed to connect to FTP: %w", err)
 	}

pkg/s3/s3.go

@@ -178,16 +178,16 @@ func (s s3Storage) Prune(retentionDays int) error {
 					Key:    object.Key,
 				})
 				if err != nil {
-					fmt.Printf("failed to delete object %s: %v\n", *object.Key, err)
+					fmt.Printf("failed to delete object %s: %v", *object.Key, err)
 				} else {
-					fmt.Printf("Deleted object %s\n", *object.Key)
+					fmt.Printf("Deleted object %s", *object.Key)
 				}
 			}
 		}
 		return !lastPage
 	})
 	if err != nil {
-		return fmt.Errorf("failed to list objects: %v\n", err)
+		return fmt.Errorf("failed to list objects: %v", err)
 	}
 
 	return nil

pkg/ssh/ssh.go

@@ -46,7 +46,7 @@ type Config struct {
 	Host         string
 	User         string
 	Password     string
-	Port         int
+	Port         string
 	IdentifyFile string
 	LocalPath    string
 	RemotePath   string
@@ -54,15 +54,15 @@ type Config struct {
 
 // createClient creates SSH Client
 func createClient(conf Config) (scp.Client, error) {
-	if _, err := os.Stat(conf.IdentifyFile); !os.IsNotExist(err) {
+	if _, err := os.Stat(conf.IdentifyFile); os.IsNotExist(err) {
 		clientConfig, err := auth.PrivateKey(conf.User, conf.IdentifyFile, ssh.InsecureIgnoreHostKey())
-		return scp.NewClient(fmt.Sprintf("%s:%d", conf.Host, conf.Port), &clientConfig), err
+		return scp.NewClient(fmt.Sprintf("%s:%s", conf.Host, conf.Port), &clientConfig), err
 	} else {
 		if conf.Password == "" {
 			return scp.Client{}, errors.New("ssh password required")
 		}
 		clientConfig, err := auth.PasswordKey(conf.User, conf.Password, ssh.InsecureIgnoreHostKey())
-		return scp.NewClient(fmt.Sprintf("%s:%d", conf.Host, conf.Port), &clientConfig), err
+		return scp.NewClient(fmt.Sprintf("%s:%s", conf.Host, conf.Port), &clientConfig), err
 
 	}
 }

pkg/ssh/ssh_test.go

@@ -1 +0,0 @@
-package ssh